New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(CONT-356) Syntax update #543
Conversation
Code now compliant with the following rules: relative_classname_inclusion relative_classname_reference parameter_documentation parameter_types top scope facts legacy facts anchor resource
Co-authored-by: Tim Meusel <tim@bastelfreak.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question on the $ensure` values
) { | ||
include ::java::params | ||
contain java::params |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why contain
here instead of include
(considering java::params
doesn't declare any resources and only sets variables).
@@ -118,12 +118,10 @@ | |||
} | |||
} | |||
|
|||
anchor { 'java::begin:': } | |||
-> package { 'java': | |||
package { 'java': | |||
ensure => $version, | |||
install_options => $package_options, | |||
name => $use_java_package_name, | |||
} | |||
-> class { 'java::config': } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
java::config
used to be contained by java
with this anchor pattern. Following this change it isn't anymore. Therefore if anyone has any calling code that eg. did a require java
or service {'foo': require => 'java'}
the configuration of java is now not guaranteed to happen first.
Code now compliant with the following rules:
relative_classname_inclusion
relative_classname_reference
parameter_documentation
parameter_types
top scope facts
legacy facts
anchor resource